Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On read, change order of dealing with redist vs undist #169

Merged
merged 3 commits into from
Aug 10, 2023

Commits on Jul 24, 2023

  1. On read, change order of dealing with redist vs undist

    The code has not properly handled the read of a Field or Array with both
    ungridded / undistributed dimensions and > 1 DE per PET. It appears that
    this is due to an incorrect ordering of dealing with these two
    situations in IO::read. This commit changes that ordering to resolve
    this issue.
    
    Note that I also needed to reassign temp_array_p to temp_array_undist_p
    before doing the redistStore and redist; without this, the redistStore
    call generated an error with this trace-back:
    
    20230724 170325.547 ERROR            PET3 ESMCI_Array.C:6238 ESMCI::Array::tRedistStore() Invalid argument  - srcArray and dstArray must provide identical number of exclusive elements
    20230724 170325.547 ERROR            PET3 ESMCI_Array.C:6018 ESMCI::Array::redistStore() Invalid argument  - Internal subroutine call returned Error
    20230724 170325.547 ERROR            PET3 ESMCI_IO.C:387 ESMCI::IO::read() Invalid argument  - Internal subroutine call returned Error
    20230724 170325.547 ERROR            PET3 ESMCI_IO.C:282 ESMCI::IO::read() Invalid argument  - Internal subroutine call returned Error
    20230724 170325.548 ERROR            PET3 ESMCI_IO_F.C:210 c_esmc_ioread() Unable to read from file  - Internal subroutine call returned Error
    20230724 170325.548 ERROR            PET3 ESMF_IO.F90:397 ESMF_IOAddArray() Unable to read from file  - Internal subroutine call returned Error
    20230724 170325.548 ERROR            PET3 ESMF_FieldPr.F90:336 ESMF_FieldRead Unable to read from file  - Internal subroutine call returned Error
    20230724 170325.548 ERROR            PET3 esmApp.F90:185 Unable to read from file  - Passing error in return code
    
    Resolves #150
    billsacks committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    5de6cf9 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Add unit tests of Field I/O with multiple DEs per PET and ungridded dim

    This tests a case that was failing until the work on this branch: each
    of these situations was tested individually, but the combination wasn't
    tested and wasn't working.
    billsacks committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    f9a80a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Configuration menu
    Copy the full SHA
    0334344 View commit details
    Browse the repository at this point in the history