Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Modified Club Detail Screen (2) #99

Merged
merged 3 commits into from
Jun 26, 2024
Merged

[FEATURE] Modified Club Detail Screen (2) #99

merged 3 commits into from
Jun 26, 2024

Conversation

KanuKim97
Copy link
Collaborator

Description

구단 Social media url 추가로 인한 수정 PR

Content

  1. 각 sns Logo를 클릭하는 경우 Intent Action을 통해 구단의 Social Media Page를 보여줍니다.
  2. Intent ActionView로 동작해 instagram의 경우 Instagram 앱의 구단 페이지를 띄워줍니다.
  3. 만약 해당 sns application이 설치되지 않았다면 일반적인 브라우저로 보여지게 됩니다.

@KanuKim97
[ADD]
6a7a026 
 - add ClubDetailUiEvent

[MOD]
 - mod ClubDetailScreen
@KanuKim97
[MOD]
8861d28 
 - mod ClubDetailScreen, ClubDetailUiEvent
@KanuKim97
[MOD]
a858212 
 - modified ClubDetailScreen

[DEL]
 - delete ClubDetailUiEvent.kt
@KanuKim97 KanuKim97 requested a review from eshc123 June 26, 2024 13:12
@KanuKim97 KanuKim97 self-assigned this Jun 26, 2024
@KanuKim97 KanuKim97 changed the title [FEATURE] Modified ClubDetail Screen(2) [FEATURE] Modified Club Detail Screen (2) Jun 26, 2024
eshc123
eshc123 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Owner

@eshc123 eshc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@eshc123 eshc123 merged commit de38b14 into dev Jun 26, 2024
1 check passed
@KanuKim97 KanuKim97 deleted the feature/mod-club-screen branch July 1, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshc123 eshc123 eshc123 approved these changes

Assignees

@KanuKim97 KanuKim97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KanuKim97 @eshc123