Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Modified Club Detail Screen (1) #97

Merged
merged 9 commits into from
Jun 24, 2024
Merged

[FEATURE] Modified Club Detail Screen (1) #97

merged 9 commits into from
Jun 24, 2024

Conversation

KanuKim97
Copy link
Collaborator

Description

  1. 수정된 디자인에 따른 UI 변경

Content

  1. GnrHorizontalDivider가 추가되었습니다.
  2. IcGridCalender와 각 SocialMedia의 로고가 추가되었습니다.
  3. ClubDetailHomePageRow, ClubDetailSocialMediaRow, ClubDetailHeaderView, ClubDetailRecentlyMatchItem 컴토넌트가 추가되었습니다.
  4. 이에 따른 ClubDetailScreen이 수정되었습니다.
  5. Domain의 Team data class에 각 요소들이 isEmpty인지 확인하는 함수들이 추가되었습니다.
  6. HomePage Url을 클릭하는 경우 홈페이지 화면을 확인할 수 있습니다.

Comment

  1. 각 sns url이 추가되면 딥링크 or 앱 링크를 통해 각 구단의 소셜미디어 화면을 보여줄 예정입니다.
  2. 현재 sis url을 받아올 수 없는 관계로 실제 화면을 보여주지는 않습니다

Screenshot

Screenshot_20240619_221641

@KanuKim97
[add]
fccd852 
 - add ClubDetailImageView
@KanuKim97
[add]
f75ce13 
 - add ClubDetailImageView
@KanuKim97
Merge branch 'dev' into feature/mod-club-screen
db09d1f
@KanuKim97
[ADD]
d67fef7 
 - add ClubDetailRecentlyMatchItem

[MOD]
 - mod ClubDetailScreen.kt,
 - mod ClubDetailUiState.kt,
 - mod RemoteTeam, Team, TeamMapper
@KanuKim97
[ADD]
033c0bd 
 - add ic_facebook, ic_x, ic_insta, IcGridCalender
 - add ClubDetailSocialMedia.kt
 - add ClubDetailHomePage.kt

[MOD]
 - mod Team, RemoteTeam, TeamMapper
 - mod Snackbar to SnackBar
 - mod Icon clickable area radius
 - mod ClubDetailView.kt, ClubDetailScreen.kt
@KanuKim97
[MOD]
8b0346d 
 - mod ClubDetailScreen
 - mod ClubDetailSocialMedia
@KanuKim97
[ADD]
03b4d59 
 - add Club Detail Top Bar
@KanuKim97
[ADD]
6a44c20 
 - add GnrHorizontalDivider

[MOD]
 - mod Team, TeamDetail
 - mod ClubDetailView, ClubDetailScreen, ClubDetailRecentlyMatchItem
 - mod ClubDetailHomePageRow
@KanuKim97
[ADD]
609a425 
 - add ClubDetailSocialMediaRow

[MOD]
 - mod TeamDetail, ClubDetailViewModel, ClubDetailScreen
@KanuKim97 KanuKim97 added the feature New feature or request label Jun 20, 2024
@KanuKim97 KanuKim97 requested a review from eshc123 June 20, 2024 13:13
@KanuKim97 KanuKim97 self-assigned this Jun 20, 2024
eshc123
eshc123 approved these changes Jun 24, 2024
View reviewed changes
Copy link
Owner

@eshc123 eshc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 고생하셨습니다!

@eshc123 eshc123 merged commit 932066b into dev Jun 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshc123 eshc123 eshc123 approved these changes

Assignees

@KanuKim97 KanuKim97

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KanuKim97 @eshc123