Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Modified Home Screen (2) #89

Merged
merged 10 commits into from
Jun 4, 2024
Merged

[FEATURE] Modified Home Screen (2) #89

merged 10 commits into from
Jun 4, 2024

Conversation

KanuKim97
Copy link
Collaborator

Description

홈 디자인 수정으로 인한 PullRequest입니다.

Content

  1. 이전에 작성된 SeasonApi가 Retrofit, DataSourceModule 등에 의존성이 선언되지 않은 것을 수정했습니다.
  2. MatchCard를 RecentlyMatchCard, UpcomingMatchCard로 나누었습니다.
  3. 글자 스타일 변경에 따른 수정 사항이 있습니다.
  4. Season Api 호출 결과를 Team DashBoard에 보여줍니다.
  5. DashBoardUiState가 추가되고, ViewModel에 StateFlow가 추가되었습니다.

Comment

  1. 현재 시즌 값을 하드코딩하여 불러오고 있습니다. 해당 현재 시즌을 불러오는 api를 통해 추가 구현이 예정되어있습니다.
  2. DashBoardItem에 현재 ClubLogo ImgUrl이 없어 표시되지 않습니다. 백엔드 Response 수정 이후 작성될 예정입니다.

Screenshot

KakaoTalk_Photo_2024-06-04-21-22-26

@KanuKim97
[MOD]
75f50be 
 - mod HomeScreen
 - mod MatchLeagueInfo
 - separate MatchCard to UpcomingMatchCard, RecentlyMatchCard
 - mod UpcomingMatchCard
 - mod RecentlyMatchCard

[ADD]
 - add GnrElevatedCard with elevation parameter
@KanuKim97
[MOD]
bc007b6 
 - UpcomingMatchCard LeagueLogo Size
@KanuKim97
[MOD]
d19596d 
 - mod UpcomingMatchCard modifier
@KanuKim97
[MOD]
cb065cc 
 - mod RecentlyMatchCard
@KanuKim97
Merge branch 'dev' into feature/mod-home-screen
afe981f
@KanuKim97
[ADD]
171fb78 
 - add DashBoardUiState.kt
 - add SeasonDataSource Dependency into NetworkDataSourceModule, NetworkModule
 - add Rank into getTotalGame Function

[MOD]
 - mod DashboardCard
 - mod GetPreviewRankListByTeamAndSeasonUseCase Parameter
 - mod HomeScreen
 - mod HomeViewModel
 - mod RecentlyMatchCard
@KanuKim97
[MOD]
3a021a8 
 - mod DateTime Format
@KanuKim97
[MOD]
a4c6fb1 
 - mod DashboardCard
@KanuKim97
[MOD]
9ffa355 
 - mod DashboardCard
@KanuKim97 KanuKim97 requested a review from eshc123 June 4, 2024 12:23
@KanuKim97 KanuKim97 self-assigned this Jun 4, 2024
@KanuKim97 KanuKim97 added the feature New feature or request label Jun 4, 2024
eshc123
eshc123 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Owner

@eshc123 eshc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

feature/home/src/main/java/com/eshc/goonersapp/feature/home/component/UpcomingMatchCard.kt Outdated

@Composable
fun UpcomingMatchCard(
modifier: Modifier = Modifier,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

순서 놓치신거 같습니다!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 넵 감사합니다 수정 후 merge하겠습니다

@KanuKim97
[MOD]
be8767e 
 - mod UpcomingMatchCard Modifier
@KanuKim97 KanuKim97 merged commit dd8f11d into dev Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshc123 eshc123 eshc123 approved these changes

Assignees

@KanuKim97 KanuKim97

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KanuKim97 @eshc123