Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] ADD MatchLineup API #84

Merged
merged 9 commits into from
May 23, 2024
Merged

[FEATURE] ADD MatchLineup API #84

merged 9 commits into from
May 23, 2024

Conversation

eshc123
Copy link
Owner

@eshc123 eshc123 commented May 23, 2024

Description

  • 기존에 /match/information 포함되어있었던 lineup 이 분리되어 신규 API로 추가되어 그에 따른 API 추가 작업 진행하였습니다.
  • MatchInformation에서는 Lineup 관련하여 삭제하였습니다.

Content

  1. Network, Data, Domain 모듈에 getMatchLineup 관련 로직 추가하였고, Fake 및 Test Code 작성하였습니다.(UseCase는 제외)

@eshc123 eshc123 requested a review from KanuKim97 May 23, 2024 13:12
@eshc123 eshc123 self-assigned this May 23, 2024
KanuKim97
KanuKim97 approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@KanuKim97 KanuKim97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eshc123 님! 확인했습니다!
👍

@eshc123 eshc123 merged commit ee4b023 into dev May 23, 2024
1 check passed
@eshc123 eshc123 deleted the feature/add-match-api branch June 10, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KanuKim97 KanuKim97 KanuKim97 approved these changes

Assignees

@eshc123 eshc123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshc123 @KanuKim97