Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Modified TopAppBar (2) #83

Merged
merged 4 commits into from
May 23, 2024
Merged

[FEATURE] Modified TopAppBar (2) #83

merged 4 commits into from
May 23, 2024

Conversation

KanuKim97
Copy link
Collaborator

Description

변경된 디자인 시안에 따른 TopAppBar 변경입니다.

Content

  1. MatchDetail에 TopAppBar가 추가되었습니다.
  2. PlayerDetail에 Transparent TopAppBar가 추가되었습니다
    • 다만, 해당 TopAppBar는 Scrollable한 View로 구성되는 경우 문제점이 있을 것으로 예상됩니다.
  3. 기존 TopAppBar의 네이밍은 GnrTopAppBar로 수정되었습니다.
  4. TopLevelDestination의 Matches가 Match로 변경되었습니다.
  5. 또한 디자인 시안에 따라 action 버튼이 추가되었습니다.
  6. Color FFC10006, FF720509이 추가되었습니다.
  7. TopAppBar의 Title Text사이즈가 변경되었습니다.

Screenshot

스크린샷 2024-05-22 22 28 15

Comment

PlayerDetail의 TopAppBar, MatchDetail의 TopAppbar는 재 수정이 필요한 것으로 사료되오니 Convention을 위주로 확인 부탁드립니다.

@KanuKim97
[MOD]
587b85c 
 - mod TopAppBar TextStyle

[ADD]
 - ADD Transparent TopAppBar on PlayerDetail Screen
@KanuKim97
Merge branch 'dev' into feature/mod-top-app-bar
aa2f554
@KanuKim97
Merge branch 'dev' into feature/mod-top-app-bar
38408d9
@KanuKim97
[MOD]
4890e46 
 - mod GnrNavHost
 - mod MatchDetailScreen
 - mod MatchNavigation
@KanuKim97 KanuKim97 added the feature New feature or request label May 22, 2024
@KanuKim97 KanuKim97 requested a review from eshc123 May 22, 2024 13:29
@KanuKim97 KanuKim97 self-assigned this May 22, 2024
eshc123
eshc123 approved these changes May 23, 2024
View reviewed changes
Copy link
Owner

@eshc123 eshc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@eshc123 eshc123 merged commit 2d722f5 into dev May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshc123 eshc123 eshc123 approved these changes

Assignees

@KanuKim97 KanuKim97

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KanuKim97 @eshc123