[FEATURE] Modified TopAppBar (1) #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
확인했습니다! BottomBar같은 경우에는 메인에서 세 개의 주 화면(Home, Match, Team)에서만 나오면 될 것 같구요! 상세 보기 등과 같은 뎁스가 하나 더 들어가는 화면에서는 BottomBar가 없어도 될 것 같습니다! |
eshc123
approved these changes
May 12, 2024
Comment on lines
72
to
89
| Scaffold( | ||
| topBar = { | ||
| TopBar( | ||
| title = "", | ||
| onBackIconClick = onBackIconClick | ||
| ) | ||
| }, | ||
| bottomBar = bottomBar | ||
| ) { paddingValues -> | ||
| MatchDetailScreen( | ||
| matchDetailUiState = matchData, | ||
| onClickChat = onClickChat, | ||
| modifier = Modifier | ||
| .fillMaxSize() | ||
| .padding(paddingValues) | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
MatchDetailScreen의 경우 TopBar가 다른 화면들과 다르게 풀스크린 화면 내에서 다른 UI 컴포넌트 위에 겹쳐서 놓여있는 형태라 고민이 필요할 것 같습니다..!
There was a problem hiding this comment.
넵 확인했습니다.
해당 파트의 경우 우선 TopBar는 삭제 처리 후에 정해진 시안 따라 처리하겠습니다.
그에 따른 MatchesDetail에 Title과 League Logo를 삽입할 예정입니다. 작업은 보류처리 하겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
변경된 디자인 시안에 따른 TopAppBar를 수정했습니다
Content
MatchesDetailScreen, TeamSearchScreen에 디자인 시안대로 TopAppBar와 BottomBar를 삽입했습니다.To Be Updated Soon...
MatchesDetail에 Title과 League Logo를 삽입할 예정입니다.Comment