Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Modified Calendar List #102

Merged
merged 7 commits into from
Jul 15, 2024
Merged

[FEATURE] Modified Calendar List #102

merged 7 commits into from
Jul 15, 2024

Conversation

KanuKim97
Copy link
Collaborator

Description

디자인 시안 변경에 따른 Calendar List형 UI 디자인입니다.

Content

  1. Calendar League Header가 추가되었습니다.
  2. Calendar Year And Month를 보여주는 Header가 추가되었습니다.
  3. List형을 보여주는 CalendarListItem이 추가되었습니다.

Question

  1. 현재 디자인 시안의 Today 버튼을 제거했습니다. 디자인 확인 후 컨펌 부탁드립니다.
  2. 예를 들어 현재 연,월이 2024.03 이라면 List 형도 2024.03을 가르켜야 할까요?
    2-1. 만약 2번 안을 구현 해야 한다면 2024.07이라면 List형으로 어떻게 표현해야할까요?

ScreenRecording

Screen_recording_20240715_211801.webm

@KanuKim97
[MOD]
e02e3c8 
 - modified CalendarListItems
@KanuKim97
[MOD]
f6854b6 
 - Modified Badge.kt, Button.kt
 - Modified Calendar.kt, ProfileMatchItem.kt

[ADD]
 - Add TodayButton.kt
@KanuKim97
[MOD]
d8ef93c 
 - Modified Calendar.kt, CalendarListStickyHeader.kt
@KanuKim97
Merge branch 'refs/heads/dev' into feature/mod-calender-grid
6e20489 
# Conflicts:
#	.idea/codeStyles/Project.xml
#	.idea/deploymentTargetSelector.xml
@KanuKim97
[MOD]
6a577ee 
 - Modified Code Convention
@KanuKim97
[MOD]
0c9a73e 
 - modified Calendar
 - modified CalendarListHeader
 - modified MatchScreen
@KanuKim97
Merge branch 'refs/heads/dev' into feature/mod-calender-list
f39fe44
@KanuKim97 KanuKim97 added the feature New feature or request label Jul 15, 2024
@KanuKim97 KanuKim97 requested a review from eshc123 July 15, 2024 12:20
@KanuKim97 KanuKim97 self-assigned this Jul 15, 2024
@KanuKim97 KanuKim97 deployed to Android CI/CD July 15, 2024 12:20 — with GitHub Actions Active
eshc123
eshc123 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Owner

@eshc123 eshc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 고생하셨습니다!

@eshc123
Copy link
Owner

eshc123 commented Jul 15, 2024

A1. Today 버튼 제거 확인하였습니다.
A2. Calendar 에서의 선택된 년도와 월이 List 화면에서 상단에 위치해서 바로 보이도록 하는 것이 자연스러울 것 같구요, 막바지에 위치한 5~7월의 경우는 스크롤을 가장 마지막에 맞추도록 하면 되지 않을까 싶습니다.

@KanuKim97 KanuKim97 merged commit 12cabfb into dev Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshc123 eshc123 eshc123 approved these changes

Assignees

@KanuKim97 KanuKim97

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KanuKim97 @eshc123