add negative test for the _is_inchikey method in CompoundIdentifier class #1334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lass
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
The
_is_inchikey
method inCompoundIdentifier
class checks whether a given string is a valid InChIKey. This method checks whether the string provided is exactly 27 characters long, splits the string into 3 parts using hyphen (-) as the seperator and then ensure that the first part has 14 characters, the second part has 10 characters, and the third part has 1 character.This PR adds negative test for the
_is_inchikey
methodChanges to be made
Add negative test case for
_is_inchikey
Test the following invalid InChIKeys:
No hyphens:
BSYNRYMUTXBXSQUHFFFAOYSA
Incorrect length:
BSYNRYMUTXBXSQ-UHFFFAOYSA-XY
Numerical characters:
12345678901234-1234567890-X
Underscore instead of hyphens:
BSYNRYMUTXBXSQ_UHFFFAOYSA-N
No last part:
BSYNRYMUTXBXSQ-UHFFFAOYSA
Status
I added the negative test case for
_is_inchikey
I ran all tests locally here
To do
If this is a work in progress, Replace this line with your next steps
Is this pull request related to any open issue? If yes, replace issueID below with the issue ID
Related to #1319