Add a positive test unit for _is_smiles when chem is none in test_compound_identifier.py #1332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_identifier.py
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
Added a positive test for _is_smiles method when chem is none in the CompoundIdentifier class. The objective is to verify the
_is_smiles
method in CompoundIdentifier class whenChem
module is not available i.e when chem=NoneChanges to be made
Patched
_pubchem_smiles_to_inchikey
which is used for converting SMILES to InCHiKey whenchem
isnone
Mocked
_pubchem_smiles_to_inchikey
method to return "InchiKey" to simulate a valid InchiKey result. Therefore indicating SMILES input is validTest with a Valid SMILES input. In this code, I used the valid SMILES string used is:
CCO
which represent Ethanol is passed tois_smiles
method.Status
Ran the test locally using pytest and it's passed all check. Proof: is_smiles - positive.log
To do
Awaiting mentors feedback
Is this pull request related to any open issue? If yes, replace issueID below with the issue ID
Related to #1319