Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CompoundIdentifier class is_input_header negative test #1328

Merged
merged 14 commits into from
Nov 18, 2024

Conversation

musasizivictoria
Copy link
Contributor

@musasizivictoria musasizivictoria commented Oct 17, 2024

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description
Added negative tests for the is_input_header method in the CompoundIdentifier class. These tests ensure that invalid headers are correctly identified by the method and return False.

Changes to be made

  1. Implement negative tests to check the method's behavior for invalid headers

Status

  • Implemented and successfully ran negative tests locally with all tests passing

To do

  • Review and ensure code coverage
  • Continue with further unit tests for other methods of the CompoundIdentifier class

Is this pull request related to any open issue? If yes, replace issueID below with the issue ID

Related to #

@DhanshreeA
Copy link
Member

@musasizivictoria could you please resolve conflicts? Thanks!

@musasizivictoria musasizivictoria changed the title Added CompoundIdentifier class is_input_header negative test Added CompoundIdentifier class is_key_header positive test Oct 17, 2024
@musasizivictoria
Copy link
Contributor Author

musasizivictoria commented Oct 17, 2024

am sorry @DhanshreeA it seems we are working on same TEST many people

@musasizivictoria musasizivictoria changed the title Added CompoundIdentifier class is_key_header positive test Added CompoundIdentifier class is_input_header negative test Oct 17, 2024
@DhanshreeA
Copy link
Member

@musasizivictoria could you please take care of the conflicts?

@musasizivictoria
Copy link
Contributor Author

@musasizivictoria could you please take care of the conflicts?

Addressed, thanks @DhanshreeA

@musasizivictoria
Copy link
Contributor Author

Also some clarity here if you don't mind
#1319 (comment)

@DhanshreeA DhanshreeA merged commit d599866 into ersilia-os:master Nov 18, 2024
18 checks passed
@musasizivictoria musasizivictoria deleted the unittestneg branch November 18, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants