-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CompoundIdentifier class is_input_header negative test #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@musasizivictoria could you please resolve conflicts? Thanks! |
musasizivictoria
force-pushed
the
unittestneg
branch
from
October 17, 2024 14:28
f8e6cb5
to
be69e21
Compare
musasizivictoria
changed the title
Added CompoundIdentifier class is_input_header negative test
Added CompoundIdentifier class is_key_header positive test
Oct 17, 2024
am sorry @DhanshreeA it seems we are working on same TEST many people |
musasizivictoria
changed the title
Added CompoundIdentifier class is_key_header positive test
Added CompoundIdentifier class is_input_header negative test
Oct 17, 2024
DhanshreeA
requested changes
Oct 23, 2024
DhanshreeA
approved these changes
Oct 23, 2024
@musasizivictoria could you please take care of the conflicts? |
Addressed, thanks @DhanshreeA |
Also some clarity here if you don't mind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed
Description
Added negative tests for the is_input_header method in the CompoundIdentifier class. These tests ensure that invalid headers are correctly identified by the method and return False.
Changes to be made
Status
To do
Is this pull request related to any open issue? If yes, replace issueID below with the issue ID
Related to #