Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_input_header negative test #1321

Closed

Conversation

Ann-Clawson
Copy link

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

Add a CompoundIdentifier class test test_is_input_header_negative in test/test_compound_identifier.py which I noticed was created in a previous open pull request for test_is_input_header_positive.

Changes to be made

Status

  • Implemented test_is_input_header_negative in test/test_compound_identifier.py
  • Tested the code locally with pytest and passed

To do

Is this pull request related to any open issue? If yes, replace issueID below with the issue ID

Related to #1319

@Ann-Clawson
Copy link
Author

Oh! I forgot to add in the "Description" section of the PR that I also added a requirements.txt file to streamline the installation of dependencies.

@dzumii
Copy link
Contributor

dzumii commented Oct 17, 2024

@Ann-Clawson Thank you so much for contributing to Ersilia but this issue is specifically for current Outreachy contributors.

@DhanshreeA
Copy link
Member

@Ann-Clawson as @dzumii mentioned we're currently not accepting contributions from anyone other than Outreachy applicants. If your PR is towards Hacktoberfest, I will have to request you to check out other participating projects. Thank you!

@DhanshreeA DhanshreeA closed this Oct 17, 2024
@Ann-Clawson
Copy link
Author

Oh! I found this repository on For Good First Issue. I'm a mid-life career changer and entry-level dev seeking opportunities to get a foot in the door of the tech world (I'm currently learning how to write unit tests 🙃). Thank you for your response, I was unaware of Outreachy and will keep an eye out for May cohort applications!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants