Fix: httpc set_options override #8878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 22 suites 10m 39s ⏱️ Results for commit 7f4340a. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
MarkoMin
force-pushed
the
fix/httpc_setoptions_override
branch
from
f3f1aad
to
762fe61
Compare
Whaileee
reviewed
Oct 2, 2024
Whaileee
removed
the
testing
|
|
Whaileee
added
testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was due to invalid validation of options that was acting like the user always passed
ipfamilyandunix_socketoptions, so each time when callingset_option(s)those options would get overridden by default values (if option values weren't present in the new options list).Validation of
ipfamilyandunix_socketcombination was not just buggy, but also insufficient because the httpc state could end up with invalid combination of those options which I proved in thehttpc_SUITE:invalid_ipfamily_unix_socket/1testcase (which fails on the current code). I also believe that there was a typo inhttpc:validate_ipfamily_unix_socket/1whereipfamilyoption got deleted twice, butunix_socketwas not, so we could end up having twounix_socketentries after validation....With the new behavior that checks current and new options
httpccan't end up having invalid ipfamily-unix_socket combo. I also believe that new error is more informative to the user on what's going on and why validation failed.I also removed deprecated
ipv6handling inhttpc_managerbecauseipv6gets translated toipfamilyoption inhttpc:validate_options/3so there is no way thatipv6entry can ever be passed tohttpc_manager.httpc_manager:set_optionsis called only fromhttpc:set_optionswhich validates (and translates)ipv6option so this should be safe.Closes #8829