Enable uppercase property matching #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solved a bug where the subject property created by PHPMailer was not translated. The if clause checked only for "=?utf-8?Q?" but PHPMailer starts its subjects with "=?UTF-8?Q?". With the extra conversion to lowercase we should be on the safe side.
|
By the way, I found out that actually I myself was the person creating a PHPMailer instance with Anyway, I think there's no harm in my pull request. Hope it's allright. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved a bug where the subject property created by PHPMailer was not translated and thus the test
$I->seeInOpenedEmailSubject('This is å wéird Swödish subjäct')was causing problems for me.The if-clause checked only for
=?utf-8?Q?but PHPMailer starts its subjects with=?UTF-8?Q?.With the extra conversion to lowercase we should be on the safe side.