Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fedora Support and CentOS Support #132

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

linuxbckp
Copy link

See issue #131

@erfanoabdi
Copy link
Owner

can u add a check to auto detect fedora, without user interaction

@linuxbckp
Copy link
Author

I tried auto-detecting, but I ran and get somewhat wrong. So I changed to manual check.

@koumaza
Copy link
Contributor

koumaza commented May 8, 2020

For RHEL, os-release may be a single line ...?
Also, does status need to be 0?

e.g.

grep -E "^NAME=" /etc/os-release | grep Fedora &>/dev/null
if [ $? = 0 ]; then

@linuxbckp
Copy link
Author

For RHEL, os-release may be a single line ...?
Also, does status need to be 0?

e.g.

grep -E "^NAME=" /etc/os-release | grep Fedora &>/dev/null
if [ $? = 0 ]; then

It works. Thanks for your unique method.

@erfanoabdi
Copy link
Owner

we already have a distro check https://github.com/erfanoabdi/ErfanGSIs/pull/132/files#diff-6aa367da3fdfc952b15def7759aa5f0bL4
add fedora here instead of grepping on top of the file again

@linuxbckp
Copy link
Author

we already have a distro check https://github.com/erfanoabdi/ErfanGSIs/pull/132/files#diff-6aa367da3fdfc952b15def7759aa5f0bL4
add fedora here instead of grepping on top of the file again

I tried and this method cannot work. See 5e1532b

@linuxbckp
Copy link
Author

Maybe https://github.com/erfanoabdi/ErfanGSIs/pull/132/files#diff-6aa367da3fdfc952b15def7759aa5f0bL4 works on 'arch' or some other distros, but not on 'fedora'.

@koumaza
Copy link
Contributor

koumaza commented May 10, 2020

Also,One caveat is that Fedora is not GNU.
In bash it says GNU.

@linuxbckp
Copy link
Author

Also,One caveat is that Fedora is not GNU.
In bash it says GNU.

I am so shocked that the setup process on Arch Linux is much easier than which on CentOS a2eae23 .

@linuxbckp linuxbckp changed the title Add Fedora Support Add Fedora Support and CentOS Support May 23, 2020
@Robert3141
Copy link

any further additions to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants