-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Replace send_pickled in CARLA drivers #233
base: master
Are you sure you want to change the base?
Conversation
6183218
to
42bbda9
Compare
Good catch, and thanks for the PR! It looks like storing pickled messages in these operators is redundant -- we can just stores messages directly. Could you update the PR to make that change? Concretely:
|
We we're doing this in order to move the pickling of large sensor messages from the critical the critical path. If we stop pre-pickling messages, and sending them using the |
Hmmm, maybe we need to re-introduce this function in ERDOS. I was under the impression that pickling a message took a negligible amount of time, but serializing a (1920, 1080, 3) numpy array takes around 15 ms on my laptop. |
Yes, I think it would be good to re-introduce this function for now in order to ensure that the driver operators do not affect our experiments. |
send_pickle
is deprecated in erdos. These changes replace the functionality ofsend_pickle
by unpickling the message then using the standardsend
method. This is necessary for when running thepseudo-asynchronous
simulator mode.