Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show specific deploy error message #35

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

CeerDecy
Copy link
Member

@CeerDecy CeerDecy commented Dec 6, 2023

Description

dice1.0 and dice2.0 : add deploy failcase to metaData

Checklist

Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/dice/2.0/internal/pkg/dice/deploy/status_check.go Outdated Show resolved Hide resolved
@erda-bot
Copy link
Member

You have no write access to use /approve instruction.

iutx
iutx previously approved these changes Dec 25, 2023
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfwn
Copy link
Member

sfwn commented Mar 6, 2024

/approve

@erda-bot erda-bot added the approved Approve merging these changes label Mar 6, 2024
@erda-bot erda-bot merged commit 384b187 into erda-project:master Mar 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approve merging these changes
Development

Successfully merging this pull request may close these issues.

4 participants