Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusing note about license compatibility #122

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

jpavlich
Copy link
Member

…xes #18, since I believe what's already in the blueprints is sufficient.

Not much to add, I guess we shoul've closed this issue a long time ago.

 #18, since I believe what's already in the blueprints is sufficient.
@jpavlich jpavlich requested a review from Bisaloo October 29, 2024 13:31
@jpavlich jpavlich linked an issue Oct 29, 2024 that may be closed by this pull request
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for playful-gelato-7892ba ready!

Name Link
🔨 Latest commit 9f7504a
🔍 Latest deploy log https://app.netlify.com/sites/playful-gelato-7892ba/deploys/6720e3c993c7350008793c0e
😎 Deploy Preview https://deploy-preview-122--playful-gelato-7892ba.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Bisaloo
Copy link
Member

Bisaloo commented Oct 29, 2024

I believe this is a tricky situation where all revolves around the very precise phrasing.

It is true that we don't want to copy GPL code in our packages because they would then probably have to be released at MIT. We can use GPL packages as dependencies without any issues though.

So maybe removing this sentence is indeed safer, even though it is accurate, to avoid confusion. What do you think?

@Bisaloo Bisaloo changed the title Removed phrase about licenses that it was not accurate. I guess it Fi… Remove confusing note about license compatibility Oct 30, 2024
@Bisaloo Bisaloo merged commit 5190c83 into main Oct 30, 2024
5 checks passed
@Bisaloo Bisaloo deleted the 18-licensing-issues branch October 30, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Licensing issues
2 participants