Signal BaseReader loop termination fix #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FiltrationImpl thread is waiting on pcap_loop from BaseReader and pcap_breakloop does not terminate it. https://github.com/the-tcpdump-group/lipcap/issues/734. Implementation steps: 1. Put lcap_loop in BaseReader in separate thread. 2. Build communication between BaseReader and that thread using conditional_variable.
kitaisreal
force-pushed
the
signal-base-reader-loop-termination-fix
branch
from
99d6f70
to
e4115c4
Compare
kitaisreal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signal BaseReader loop termination fix.
Motivation: The problem is that FiltrationImpl manager is sitting on pcap_loop that started from BaseReader and pcap_breakloop does not terminate it, according to documentation pcap_breakloop should not terminate it. As a solution I decided to put it in separate thread, make communication through conditional variable and cancel loop with pthread_cancel. Please check following links:
the-tcpdump-group/libpcap#734
https://linux.die.net/man/3/pcap_breakloop
https://www.tcpdump.org/manpages/pcap_breakloop.3pcap.html