Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.5] Refactor EVMExecutor::call #202

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

elmato
Copy link
Contributor

@elmato elmato commented Sep 4, 2024

Closes #201 #203 #204

@elmato elmato requested a review from taokayan September 4, 2024 05:04
taokayan
taokayan previously approved these changes Sep 4, 2024
@taokayan
Copy link
Contributor

Confirmed the vmTrace and stateDiff look good:

The CALL operation now cost 6930 (which indicates the coinbase address access is WARM)

{"cost":6930,"ex":{"mem":null,"push":["0x1"],"store":null,"used":10679},"idx":"0-79-1784","op":"CALL","pc":7495,"sub":{"code":"0x","ops":[]}}

also the local stateDiff of balance matched the gast cost of 65152

"stateDiff":{"0x2787b98fc4e731d0456b3941f0b3fe2e01439961(=225677405358936338996207363186719272191895247201)":{"balance":{"*":{"from":"0xd3b9f9d33d6bc438df9c(=999849977338799999999900)","to":"0xd3b9f96a45dab38bdf9c(=999849947793199999999900)"}}

seems i got the assertion error followed by the crash in rpc during the get balance request:

       [09-11|08:04:06.369 UTC] Silkrpc build info: eos-evm-rpc version: v1.0.0-0f57f379f6bfd58e211750537617af37d4312b05-dirty
       [09-11|08:04:06.369 UTC] Silkrpc libmdbx version: v0.12.0-71-g1cac6536 build: x86_64-ELF-Linux-Release compiler: cc (Ubuntu 11.4.0-2ubuntu1~20.04) 11.4.0
       [09-11|08:04:06.369 UTC] Silkrpc launched with datadir "./chain-data" using 6 contexts, 16 workers
       [09-11|08:04:06.371 UTC] Skip protocol version compatibility check with core services
       [09-11|08:04:06.371 UTC] Starting ETH RPC API at 0.0.0.0:8881 ENGINE RPC API at 
       [09-11|08:04:06.371 UTC] Silkrpc is now running [pid=46'140, main thread=129'293'520'733'760]
Assert failed: max_fee_per_gas >= base_fee_per_gas Source: /home/kayan-u20/workspaces/eos-evm-node/external/silkworm/silkworm/core/types/transaction.cpp, line 459./kayan_rpc.sh: line 5: 46140 Aborted                 (core dumped) ./eos-evm-rpc-new --chain-id=15557 --api-spec=eth,debug,net,trace --http-port=0.0.0.0:$port --eos-evm-node=127.0.0.1:8080 --chaindata=./chain-data $@

@taokayan taokayan dismissed their stale review September 12, 2024 00:26

need to fix the crash of "Assert failed: max_fee_per_gas >= base_fee_per_gas"

@arhag arhag changed the title Refactor EVMExecutor::call [1.0.5] Refactor EVMExecutor::call Sep 12, 2024
Copy link
Contributor

@taokayan taokayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed balance check via RPC is fine and the number matched with antelope:

{

  "rows": [{

      "id": 0,

      "eth_address": "2787b98fc4e731d0456b3941f0b3fe2e01439961",

      "nonce": 4,

      "balance": "00000000000000000000000000000000000000000000d3b9f96a45dab38bdf9c(=999849947793199999999900)",

      "code_id": null,

      "flags": 0

    }

  ],

  "more": false,

  "next_key": ""

}

------------------------------------

now checking balances via ETH-RPC http://127.0.0.1:8881

EOS balance of address 2787b98fc4e731d0456b3941f0b3fe2e01439961 is 999849947793199999999900 EOS

@elmato elmato merged commit 944f319 into release/1.0 Sep 13, 2024
5 checks passed
@elmato elmato deleted the elmato/use-gas-parameters-trace-executor branch September 13, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants