fixed issue with sparse direction;

was overwriting a vector (Python is thinly disguised C)
enzbus · Jun 4, 2024 · 9c4b1d9 · 9c4b1d9
1 parent 22a6a75
commit 9c4b1d9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/project_euromir/tests/lbfgs.py b/project_euromir/tests/lbfgs.py
@@ -93,7 +93,7 @@ def lbfgs_multiply(
         rhos[i] = 1. / np.dot(past_steps[i], past_grad_diffs[i])
 
     # using paper notation
-    q = current_gradient
+    q = np.copy(current_gradient)
 
     # right part, backward iteration
     alphas = np.empty(memory, dtype=float)
@@ -218,7 +218,7 @@ def minimize_lbfgs(
             scale = np.dot(past_steps[-1], past_grad_diffs[-1]) / np.dot(
                 past_grad_diffs[-1], past_grad_diffs[-1])
 
-        direction[:] = - _lbfgs_multiply_dense(
+        direction[:] = - lbfgs_multiply(
             current_gradient=current_gradient,
             past_steps=past_steps[memory-i:],
             past_grad_diffs=past_grad_diffs[memory-i:],