fix: improve error handling for export downloads #1694
+39
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Separate feature detection try/catch from server error handling - Replace alert with proper error notifications - Add localized error messages for browser support and download errors
|
|
Visit the preview URL for this PR (updated for commit 8e9105d): https://ent-enki-dev--pr1694-fix-download-file-fe-8l0jsbmb.web.app (expires Mon, 02 Dec 2024 13:28:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 50f71a028b1cba336bad43cc33ce2755ca3f1855 |
testower
commented
Dec 4, 2024
| @@ -650,4 +650,10 @@ export const messages: MessagesKey = { | |||
| mapLoadingStopsDataText: 'Loading stops...', | |||
| locateStopPoint: 'Locate', | |||
| locateStopPointTooltip: 'Locate on map', | |||
| exportsDownloadUnsupportedBrowserTitle: 'Browser Not Supported', | |||
There was a problem hiding this comment.
Swedish: Webbläsaren stöds inte
testower
commented
Dec 4, 2024
| @@ -650,4 +650,10 @@ export const messages: MessagesKey = { | |||
| mapLoadingStopsDataText: 'Loading stops...', | |||
| locateStopPoint: 'Locate', | |||
| locateStopPointTooltip: 'Locate on map', | |||
| exportsDownloadUnsupportedBrowserTitle: 'Browser Not Supported', | |||
| exportsDownloadUnsupportedBrowserMessage: | |||
| 'Sorry, your browser does not support file downloads.', | |||
There was a problem hiding this comment.
Swedish: Din webbläsare stöder inte nedladdning av filer.
testower
commented
Dec 4, 2024
| exportsDownloadUnsupportedBrowserTitle: 'Browser Not Supported', | ||
| exportsDownloadUnsupportedBrowserMessage: | ||
| 'Sorry, your browser does not support file downloads.', | ||
| exportsDownloadErrorTitle: 'Download Failed', |
There was a problem hiding this comment.
Swedish: Nedladdning misslyckades
testower
commented
Dec 4, 2024
| 'Sorry, your browser does not support file downloads.', | ||
| exportsDownloadErrorTitle: 'Download Failed', | ||
| exportsDownloadErrorMessage: | ||
| 'An error occurred while downloading the export. Please try again.', |
There was a problem hiding this comment.
Swedish: Ett fel har uppstått medan filen laddades ner. Försök igen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1357
Pending translations for Swedish and Finnish