Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature detection for export downloads is too broad #1357

Open
testower opened this issue May 8, 2024 · 0 comments · May be fixed by #1694
Open

Feature detection for export downloads is too broad #1357

testower opened this issue May 8, 2024 · 0 comments · May be fixed by #1694

Comments

@testower
Copy link
Collaborator

testower commented May 8, 2024

The try/catch surround the feature detection for export downloads masks other errors, e.g. server errors:

This is the feature detection code:

    const isFileSaverSupported = !!new Blob();

The try/catch should wrap only this line of code. Other errors should be handled separately.

Additionally:

  • We should not use an alert to display the error message
  • The error message should be localized
@testower testower linked a pull request Nov 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant