Reduce pressure on checksumCache-map

entur · Mar 21, 2024 · 28cfe79 · 28cfe79
1 parent 0f8d63c
commit 28cfe79
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/main/java/no/rutebanken/anshar/data/VehicleActivities.java b/src/main/java/no/rutebanken/anshar/data/VehicleActivities.java
@@ -335,7 +335,11 @@ public Collection<VehicleActivityStructure> addAll(String datasetId, List<Vehicl
                         activity.setValidUntilTime(validUntilTime);
                     }
 
-                    String existingChecksum = checksumCache.get(key);
+                    String existingChecksum = null;
+                    if (checksumCache.containsKey(key)) {
+                        existingChecksum = checksumCache.get(key);
+                    }
+
                     timingTracer.mark("checksumCache.get");
 
                     boolean updated;
@@ -370,11 +374,6 @@ public Collection<VehicleActivityStructure> addAll(String datasetId, List<Vehicl
                             checksumCacheTmp.put(key, currentChecksum);
                         } else {
                             outdatedCounter.incrementAndGet();
-
-                            //Keeping all checksums for at least 5 minutes to avoid stale data
-                            checksumCache.set(key, currentChecksum, 5, TimeUnit.MINUTES);
-                            timingTracer.mark("checksumCache.set");
-
                         }
 
                         if (!isLocationValid(activity)) {invalidLocationCounter.incrementAndGet();}