-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jumpstart network #918
Merged
Merged
Jumpstart network #918
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
2ea8b13
Jumpstart network
JesseAbram 596b50f
some tests
JesseAbram 0518683
add confirmation check
JesseAbram c2fbb1e
fix jump start details test
JesseAbram 88478a5
test jump start
JesseAbram b11c139
jump start threshold side test
JesseAbram 063e9cd
jumpstart test
JesseAbram 18ccbff
test master key sign
JesseAbram 7e75fb2
fmt
JesseAbram a1d690b
fmt
JesseAbram 1c27b58
add benchmarks to register
JesseAbram 5b2d3d4
clean
JesseAbram 517109e
changelog
JesseAbram e236be6
clean
JesseAbram 1600811
Apply suggestions from code review
JesseAbram 7c77aea
fixes
JesseAbram 879cba6
add comment
JesseAbram 84c1770
fix
JesseAbram 8c7338d
Apply suggestions from code review
JesseAbram 237078b
fix
JesseAbram 0466073
change master to parent
JesseAbram f726f51
fix build
JesseAbram 5fcacb0
fix build
JesseAbram 8917d32
fix
JesseAbram cc7e7de
Update crates/threshold-signature-server/src/user/errors.rs
JesseAbram 1ec04d7
fix
JesseAbram 4d8fb55
Merge branch 'master' of github.com:entropyxyz/entropy-core into jump…
JesseAbram File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion: instead of overwriting the parent's verifying key to be
0x00
we couldhave a separate "forbidden key" entry,
PARENT_VERIFYING_KEY
, which points to the parentverifying key.
For those checks you mention, we could achieve them the same way, but doing an extra
lookup.
That way we keep the verifying key entries consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure at this point tho im in favour of opening an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah an issue is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#931