Update Synedrion usage to v0.0.12

[fjarri]

• Fixes Move to a tagged release of synedrion, not a branch with a fix #509
• Fixes Refactor pre protocol execution  #416
• Public vs AccountId32 #376 is still open: even though we're using PublicKey instead of Public now, the problem still stands: we have AccountId32 and Public with identical contents.
• VerifierWrapper was removed, PartyId now implements the necessary traits directly.
• ProtocolMessage does not make a distinction between broadcast and direct messages anymore, since our messaging is direct-only. There is still a distinction in the protocol execution loop, but it will be removed when message bundling is implemented (see Message bundling synedrion#62)
• Removed a check for messages sent to ourselves in the protocol loop because evidently it is now checked in protocol_transport/mod.rs
• Generalized the three protocol loops.
• Note that "my_idx" is not being passed anymore from the upper levels; this information is already present in the relation between the signer and the verifiers, and if the signer's key is not present among the verifiers, there will be an error on the session creation stage (synedrion::sessions::Error::Local).

[vercel]

@fjarri is attempting to deploy a commit to the entropyxyz Team on Vercel.

A member of the Team first needs to authorize it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
entropy-core	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 28, 2023 9:07pm

[ameba23]

• May invalidate Public vs AccountId32 #376: we're using PublicKey instead of Public now, but the problem still stands: for whatever reason Substrate has two different types which are "equivalent" (https://docs.rs/subxt-signer/latest/subxt_signer/sr25519/struct.PublicKey.html), but there's no From to convert between them, so I have to do it manually.

I don't think it will resolve this issue completely, but i am planning to ditch subxt_signer now that we figured out how to use sp_core::sr25519 on wasm. So it will go back to being Public rather than PublicKey. Which i guess has a From <AccountId32> but don't know how much that will help. I can try to get this done today unless it turns out to be a complicated one.

[fjarri]

Not sure why the tests are not being run.

[ameba23]

Are broadcast destinations sometimes different on different rounds? As in, does this need to be called inside the round loop?

[fjarri]

Not at the moment, no. But compared to other parts of the loop it takes negligible time to generate that vector, and I didn't want to want to introduce additional state that the user needs to maintain. Moreover, with entropyxyz/synedrion#62 the broadcast part will go away anyway, there will only be direct messages left.

[ameba23]

Cool! This also fixes #416

And if i've understood right, we no longer rely on array indexes to identify parties, so no more issues around ordering of account IDs.

[fjarri]

There is still some ordering exposed, since there is a fixed order of key shares in KeyShare, and the order of PartyIds given to the session constructor must match it. I cannot include PartyId in the share itself since the verifiers are external to Synedrion, plus as far as I understand we want one share to be kept on multiple nodes.

[ameba23]

Looks great. How did you get CI to run in your fork in the end?