Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger attestation check during validate #1063

Merged
merged 47 commits into from
Oct 2, 2024
Merged

Trigger attestation check during validate #1063

merged 47 commits into from
Oct 2, 2024

Commits on Sep 23, 2024

  1. Switch to using a StorageDoubleMap instead

    @HCastano
    HCastano committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2dd92b4 View commit details
    Browse the repository at this point in the history

  2. Use loose coupling between attestation and staking extension pallets 

    With the tight coupling we're not able to build out a mock runtime for the staking extension pallet
since the compiler isn't able to verify that we have an implementation of the staking extension
pallet for our mock attestation pallet (yeah, bit of a roundabout thing...).

The loose coupling gives us a bit of flexibility here, and also allows us to scope the iteraction
between the pallets in a more fine grained way.
    @HCastano
    HCastano committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    74e1ef4 View commit details
    Browse the repository at this point in the history

  3. Update test mocks to use loose coupling

    @HCastano
    HCastano committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e41b8ec View commit details
    Browse the repository at this point in the history

  4. Appease Clippy

    @HCastano
    HCastano committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ccce0c3 View commit details
    Browse the repository at this point in the history

  5. Add associated types to runtime implementation of pallet_attestation

    @HCastano
    HCastano committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    382a6e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Change how an X25519 public key is grabbed from storage 

    We can't rely on the `ThresholdToStash` or `ThresholdServer` storage
entries being populated anymore.
    @HCastano
    HCastano committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b7aeea5 View commit details
    Browse the repository at this point in the history

  2. Update attestation pallet to use new interface

    @HCastano
    HCastano committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9b3f11c View commit details
    Browse the repository at this point in the history

  3. Write happy path test for full validate + attest flow

    @HCastano
    HCastano committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0b54e11 View commit details
    Browse the repository at this point in the history

  4. Fix compliation of pallet_propagation tests

    @HCastano
    HCastano committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    dd21370 View commit details
    Browse the repository at this point in the history

  5. TaploFmt

    @HCastano
    HCastano committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    79c8237 View commit details
    Browse the repository at this point in the history

  6. Remove dbg! statements

    @HCastano
    HCastano committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    06f664e View commit details
    Browse the repository at this point in the history

  7. Use Weight::zero() instead of 0.into()

    @HCastano
    HCastano committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    13f47c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Fix staking pallet tests

    @HCastano
    HCastano committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    54bf340 View commit details
    Browse the repository at this point in the history

  2. Add new event for validate extrinsic

    @HCastano
    HCastano committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    07b5013 View commit details
    Browse the repository at this point in the history

  3. Inline some imports

    @HCastano
    HCastano committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    bbdc743 View commit details
    Browse the repository at this point in the history

  4. Add some docs around the key provider and attestation queue

    @HCastano
    HCastano committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    661121f View commit details
    Browse the repository at this point in the history

  5. Clean up docs around validation queue

    @HCastano
    HCastano committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    102fd57 View commit details
    Browse the repository at this point in the history

  6. Use counted double map for validation queue 

    We're going to try and use this to limit the number of entries for benchmarking purposes.
    @HCastano
    HCastano committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e253047 View commit details
    Browse the repository at this point in the history

  7. Use new NMap key syntax for staking tests

    @HCastano
    HCastano committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f76561b View commit details
    Browse the repository at this point in the history

  8. Add limit to number of pending attestations in queue

    @HCastano
    HCastano committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ff90202 View commit details
    Browse the repository at this point in the history

  9. Add test for max pending attestations

    @HCastano
    HCastano committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8e85de2 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Hardcode pending attestation limit 

    The compiler is complaining abou a missing `Div` implementation which I'm not really sure how to
work around.
    @HCastano
    HCastano committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    4683974 View commit details
    Browse the repository at this point in the history

  2. Add benchmark for Staking Extension's on_initialize hook

    @HCastano
    HCastano committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    706c51d View commit details
    Browse the repository at this point in the history

  3. Fix a few staking pallet benchmarks

    @HCastano
    HCastano committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9c53231 View commit details
    Browse the repository at this point in the history

  4. RustFmt

    @HCastano
    HCastano committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3449d1b View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Add hack for writing to Staking pallet storage from Attestation benches 

    This isn't the best solution, but for now it needs to be done since the `attest()` extrinsic expects
certain Staking pallet specific data structures to be populated before it has try and verify an
attestation.
    @HCastano
    HCastano committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    af06541 View commit details
    Browse the repository at this point in the history

  2. RustFmt

    @HCastano
    HCastano committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8acb8e5 View commit details
    Browse the repository at this point in the history

  3. Run through benchmark for Staking::on_intialize()

    @HCastano
    HCastano committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    14af641 View commit details
    Browse the repository at this point in the history

  4. Run through benchmark for Attestation::on_intialize()

    @HCastano
    HCastano committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7cc89ff View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into hc/add-attestation-check-to-validate

    @HCastano
    HCastano committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    bf3000f View commit details
    Browse the repository at this point in the history

  6. Add new method to key handler for dealing with PCKs

    @HCastano
    HCastano committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    ecdad8f View commit details
    Browse the repository at this point in the history

  7. Bump TDX Quote and fix staking tests

    @HCastano
    HCastano committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9a02898 View commit details
    Browse the repository at this point in the history

  8. Clean up KeyProvider implementation

    @HCastano
    HCastano committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    b59a008 View commit details
    Browse the repository at this point in the history

  9. Fix attestation benchmarks

    @HCastano
    HCastano committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    79ec172 View commit details
    Browse the repository at this point in the history

  10. Fix staking benchmarks

    @HCastano
    HCastano committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f75a8ed View commit details
    Browse the repository at this point in the history

  11. Rename X25519KeyProvider to KeyProvider 

    This reflects the more generic nature of the trait now.
    @HCastano
    HCastano committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6f023f2 View commit details
    Browse the repository at this point in the history

  12. RustFmt

    @HCastano
    HCastano committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    143569c View commit details
    Browse the repository at this point in the history

  13. Add check for expected values in test

    @HCastano
    HCastano committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d712e2d View commit details
    Browse the repository at this point in the history

  14. Add note about pallet ordering for on_initialize()

    @HCastano
    HCastano committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    07b1c31 View commit details
    Browse the repository at this point in the history

  15. RustFmt

    @HCastano
    HCastano committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d942404 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Clean up some small things

    @HCastano
    HCastano committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    78c74bf View commit details
    Browse the repository at this point in the history

  2. Use randomness in quote generation

    @HCastano
    HCastano committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    34f33c8 View commit details
    Browse the repository at this point in the history

  3. Add test randomness provider to Propagation mock

    @HCastano
    HCastano committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0cd8167 View commit details
    Browse the repository at this point in the history

  4. Add CHANGELOG entry

    @HCastano
    HCastano committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a62cf31 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Change method comment into doccomment

    @HCastano
    HCastano committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    56be187 View commit details
    Browse the repository at this point in the history

  2. Clarify accounts used in ValidationQueue

    @HCastano
    HCastano committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    0e5187a View commit details
    Browse the repository at this point in the history

  3. Add error type for missing PCK

    @HCastano
    HCastano committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a7c435d View commit details
    Browse the repository at this point in the history