Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mob][photos] extract remaining strings + localization of 'MagicFilters' #4150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simondubrulle
Copy link
Contributor

Similar to #4118 (used same methodology) @laurenspriem

Description

I have :

  • extracted most of the remaining strings (I am excluding all strings related to debug pages)
  • fixed an issue where the magic filters would only show in english in hierarchical search (were not localized using the built in 'getLocalizedTitle ' function). Modified file is mobile/lib/utils/hierarchical_search_util.dart

Tests

Tested on my Pixel 6a

Built with :

Flutter 3.24.3
JDK 17.0.2
Gradle 7.2

…uld always show in english in hierarchical search
@simondubrulle simondubrulle changed the title [mob][photos] extract remaining strings + fixed issue where 'magic' items wo… [mob][photos] extract remaining strings + localization of 'MagicFilters' Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant