This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Update code style to use rust fmt. #1823
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMauderer
force-pushed
the
wip/mm/apply_rust_fmt_requirement
branch
from
5b94c33 to
684ece4
Compare
MichaelMauderer
force-pushed
the
wip/mm/apply_rust_fmt_requirement
branch
4 times, most recently
from
25c7639 to
5772d39
Compare
farmaazon
reviewed
Aug 31, 2021
docs/contributing/style-guide.md
Outdated
Comment on lines
183
to
188
| ### Multiline Expressions | ||
| Most (preferably all) expressions should be single line. Multiline expressions | ||
| are hard to read and introduce noise in the code. Often, it is also an indicator | ||
| of code that is not properly refactored. Try to refactor parts of multiline | ||
| expressions to well-named variables, and divide them to several single-line | ||
| expressions. |
There was a problem hiding this comment.
We should consider keeping the requirement of "Try to refactor parts of multiline
expressions to well-named variables", however I'm not very fond of hard "one-line" restriction.
wdanilo
suggested changes
Sep 3, 2021
MichaelMauderer
force-pushed
the
wip/mm/apply_rust_fmt_requirement
branch
from
79ef476 to
571227a
Compare
MichaelMauderer
force-pushed
the
wip/mm/apply_rust_fmt_requirement
branch
4 times, most recently
from
4b6f170 to
b06f06a
Compare
MichaelMauderer
force-pushed
the
wip/mm/apply_rust_fmt_requirement
branch
from
b06f06a to
adceeec
Compare
MichaelMauderer
force-pushed
the
wip/mm/apply_rust_fmt_requirement
branch
from
adceeec to
e278399
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Updates the codebase/CI to use rust fmt style and updates the style guide.
[ci no changelog needed]
Important Notes
Check the different commits for better overview of the changes.
Checklist
Please include the following checklist in your PR:
TheCHANGELOG.mdwas updated with the changes introduced in this PR.The documentation has been updated if necessary.All code has automatic tests where possible.All code has been profiled where possible.All code has been manually tested in the IDE.All code has been manually tested in the "debug/interface" scene.All code has been manually tested by the PR owner against our test scenarios.All code has been manually tested by at least one reviewer against our test scenarios.