Add Typescript declarations #56

timhc22 · 2021-03-17T02:32:06Z

No description provided.

makoto · 2021-03-17T11:12:18Z

.gitignore

@@ -2,3 +2,4 @@ node_modules
 dist
 yarn-error.log
 *.DS_Store
+.idea


What is .idea ? Can you remove it?

makoto · 2021-03-17T11:20:03Z

src/index.d.ts

+    provider: ethers.providers.Provider;
+    signer: any;
+    ens: any;
+    name(name: any): Name;


name: any should be name: string

makoto · 2021-03-17T11:20:43Z

src/index.d.ts

+    signer: any;
+    ens: any;
+    name(name: any): Name;
+    resolver(address: any): Resolver;


address: any should be address:string

makoto · 2021-03-17T11:20:48Z

src/index.d.ts

+    ens: any;
+    name(name: any): Name;
+    resolver(address: any): Resolver;
+    getName(address: any): Promise<{


address: any should be address:string

makoto · 2021-03-17T11:21:19Z

src/index.d.ts

+    getName(address: any): Promise<{
+        name: any;
+    }>;
+    getNameWithResolver(address: any, resolverAddr: any): Promise<{


both address and resolverAddress should be string

makoto · 2021-03-17T11:22:23Z

src/index.d.ts

+    getNameWithResolver(address: any, resolverAddr: any): Promise<{
+        name: any;
+    }>;
+    setReverseRecord(name: any, overrides: any): Promise<any>;


name should be string

makoto · 2021-03-17T11:22:49Z

src/index.d.ts

+    namehash: string;
+    ens: any;
+    ensWithSigner: any;
+    name: any;


name should be string

makoto · 2021-03-17T11:23:02Z

src/index.d.ts

+    signer: any;
+    resolver: any;
+    getOwner(): Promise<any>;
+    setOwner(address: any): Promise<any>;


address: any should be address:string

makoto · 2021-03-17T11:23:08Z

src/index.d.ts

+    getOwner(): Promise<any>;
+    setOwner(address: any): Promise<any>;
+    getResolver(): Promise<any>;
+    setResolver(address: any): Promise<any>;


address: any should be address:string

makoto · 2021-03-17T11:23:50Z

src/index.d.ts

+    setResolver(address: any): Promise<any>;
+    getTTL(): Promise<any>;
+    getResolverAddr(): Promise<any>;
+    getAddress(coinId: any): Promise<any>;


coinId is number

makoto · 2021-03-17T11:24:07Z

src/index.d.ts

+    getTTL(): Promise<any>;
+    getResolverAddr(): Promise<any>;
+    getAddress(coinId: any): Promise<any>;
+    setAddress(key: any, address: any): Promise<any>;


key and address should be string

makoto · 2021-03-17T11:24:52Z

src/index.d.ts

+    setSubnodeOwner(label: any, newOwner: any): Promise<any>;
+    setSubnodeRecord(label: any, newOwner: any, resolver: any, ttl?: number): Promise<any>;
+    createSubdomain(label: any): Promise<any>;
+    deleteSubdomain(label: any): Promise<any>;


All label, newOwner, resolverandkeyabove should bestring`

makoto · 2021-03-17T11:26:03Z

src/index.d.ts

+}
+declare class Resolver {
+    constructor({ address, ens }: {
+        address: any;


address: any should be address:string

makoto · 2021-03-17T11:26:08Z

src/index.d.ts

+        address: any;
+        ens: any;
+    });
+    address: any;


address: any should be address:string

makoto · 2021-03-17T11:26:22Z

src/index.d.ts

+    });
+    address: any;
+    ens: any;
+    name(name: any): Name;


name: any should be name:string

makoto · 2021-03-17T11:31:50Z

src/index.js

+/**
+ * Get ENS Contract
+ *
+ * // todo is Provider here meant to be provider from web3-core ? (may need to upgrade web3 library)


Save as above

makoto · 2021-03-17T11:31:54Z

src/index.js

@@ -19,10 +19,25 @@ function getEnsAddress(networkId) {
  }
 }

+/**
+ * Get Resolver Contract
+ * // todo is Provider here meant to be provider from web3-core ? (may need to upgrade web3 library)


The provider is used at ethers.Contract so whatever the type definition ethers.io uses. Ethers.js is written in Type script so probably you can import type from there?

makoto · 2021-03-17T11:32:46Z

src/utils/contents.d.ts

@@ -0,0 +1,12 @@
+export function decodeContenthash(encoded: any): {
+    protocolType: any;


makoto · 2021-03-17T11:37:05Z

Do we need any instruction on README on how to use this type definitions?

…enerated by contributors who may use an IDE

martriay · 2021-03-28T18:31:41Z

Why was this closed?

timhc22 · 2021-03-28T18:38:36Z

@martriay, I made an error, it is still open, but here:

ensdomains/ensjs#58

Add Typescript declarations

16cf294

timhc22 mentioned this pull request Mar 17, 2021

TypeScript Support #46

Open