This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Update README #187
Closed
Update README #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove note about node-gyp issues during installation. Since libxslt is now an optional peer dependency, it will not be installed along with enketo-transformer, so this note is irrelevant. In 'Prerequisites', we tell people to install libxslt separately (if necessary) and we do inform them of the requirements there.
Add note that may help people experiencing https://github.com/enketo/enketo-transformer/issues/185
|
Thanks so much for this, @JGreenlee! We're just about to complete a migration to a monorepo (enketo/enketo#761). If you don't mind reopening your PR against https://github.com/enketo/enketo that would be wonderful or I can do it when I archive the individual repositories. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since libxslt is now an optional peer dependency, it will not be installed along with enketo-transformer, so this note is irrelevant.
In 'Prerequisites', we tell people to install libxslt separately (if necessary) and we do inform them of the requirements there.