Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

Revert "Override Docker ENTRYPOINT…" #582

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

eyelidlessness
Copy link
Contributor

When run with downstream images such as ODK Central's, the ENTRYPOINT change (#571) results in 404 responses from the transformation API endpoint. As we're preparing a release (#581), we're temporarily rolling back that change so we can investigate further.

@lognaturel lognaturel merged commit 5c9a470 into enketo:master Aug 21, 2023
2 checks passed
@lognaturel
Copy link
Contributor

FYI @jnm. We consider the image part of EE's public API so we'll want to make any changes that may require downstream images to change as part of a major release. ENTRYPOINT commands can't be overridden so any consumers that have used CMD in the past would have to change to ENTRYPOINT. This is likely surprising since node's own docs recommend using CMD: https://nodejs.org/en/docs/guides/nodejs-docker-webapp

We could consider a short-term likely fix of using the CMD exec form. This is what Central's image that uses EE's as a parent does and it does stop instantly. My understanding of the node images' docker-entrypoint.sh is that it directly runs commands with node if appropriate or otherwise essentially lets CMD override it.

Otherwise we do intend to change the Docker setup soon in a breaking way (enketo/enketo#935) and could include this change then if we really think ENTRYPOINT is appropriate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants