This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified this PR works with
What else has been done to verify that this works as intended?
It builds, and appears to run (at least to the predictable point of failing to connect to Redis, which I believe is out of scope for this). The NPM version needed to be made explicit for build to succeed.
Why is this the best possible solution? Were any other approaches considered?
It's not. We should reevaluate what is an appropriate base image, and more explicitly manage dependencies and their versions—ideally at the project level, but at least in a consistent way (e.g. Volta for Node version management). And we should eliminate unneeded dependencies (e.g. Python).
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The Docker image is using a different minor version of Node and NPM than the project, which could be a risk. But we're going to address the project level separately as part of enketo/enketo#951.
Do we need any specific form for testing your changes? If so, please attach one.
N/A.