[azure-kubernetes] Fix LTS dates #6166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request 👍. If you are not familiar with the project, please check out our Contributing Guidelines and our Guiding Principles. Also take a look at our Hacking Guide if you intend to work on site internals. |
|
cc @MathieuPuech @chenrui333 as author and reviewer of #6123 |
chenrui333
added
the
release-updates
usta
changed the title
|
Could you make at least the dates of (releae ) 1.30 and 1.7's lts/eol dates same ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6123 an LTS date for Azure Kubernetes
1.30was added. The fields used are inconsistent with the existing LTS dates for1.27.In
1.27theeolfield was used for the LTS EOL date, and theltsfield was used for the original non-LTS eol date. In1.30these fields have been switched. The1.27data also has aneoasfield with the same value asltswhich gets rendered as a field calledsupportwhich does not exist for1.30.It makes more sense to me to use the
eolfield for the original non-LTS EOL date, and theltsfield for the extended LTS EOL date. So this PR updates the1.27data to be consistent with the1.30data.