-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[node.js] Add new commercial support column. #6048
base: master
Are you sure you want to change the base?
[node.js] Add new commercial support column. #6048
Conversation
Thank you for opening this pull request 👍. If you are not familiar with the project, please check out our Contributing Guidelines and our Guiding Principles. Also take a look at our Hacking Guide if you intend to work on site internals. |
We already have a eoes column, which is being used for any kind of extended support, including commercial. Lets use that instead of defining a new column. See the https://endoflife.date/angular page for example. |
@captn3m0 Happy to do that but it doesn't look to me that the column will work for this. The logic uses the date (in part) to determine the status/color:
That may have worked for the Angular support but for this product support is not dependent on the date in any way:
What if I add some commentary with the code that explains why this extra column is required? |
I suppose I could alter the code to handle a "hard yes" and a "hard no." Not attached to either way, just let me know what you'd like me to do. :-) |
@captn3m0 I'm reviewing the code in product.html and I'm seeing duplication:
And two of these but they are slightly different:
|
Can you clarify what's the duplication? It's three separate columns Further, you can leave
You can see an example at https://endoflife.date/eclipse-jetty. We are generally wary of adding new columns - this means new API/schema changes which need a lot more thought. Since there's only a single extended support available (which happens to be commercial), lets use |
@captn3m0 for the duplication comment, I retract that: I read too quickly and thought the variable names were the same. Thank you for your other comments, that clarified things for me and I've submitted changes that produce the following result: |
@captn3m0 checking in...is this better? Cheers. |
This reverts commit 28fd97b652bc4be9e4556dc6ae3f75d733308ea8.
This reverts commit 9b86f4a.
The changes in this PR are: