Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new-product]: nginx-ingress-controller #6043

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

[new-product]: nginx-ingress-controller #6043

wants to merge 17 commits into from

Conversation

Jubblin
Copy link

@Jubblin Jubblin commented Oct 18, 2024

No description provided.

captn3m0
captn3m0 requested changes Oct 20, 2024
View reviewed changes
Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs release cycles and eol dates

ingress-nginx.md Outdated Show resolved Hide resolved
ingress-nginx.md Outdated Show resolved Hide resolved
@chenrui333 chenrui333 added the new-product This PR adds a new product to the website. label Oct 22, 2024
@Jubblin Jubblin requested a review from captn3m0 December 13, 2024 13:06
@usta
Copy link
Member

usta commented Dec 13, 2024

@Jubblin why the dates are like &id005 2023-11-01 00:00:00 ? Could you fix formating for those

@usta
Copy link
Member

usta commented Dec 13, 2024

@captn3m0 did we change date formating ?

@usta
Copy link
Member

usta commented Dec 14, 2024

@Jubblin are you filling dates using some kind of script ? I do believe you can fix these by hand way faster.
Right now it is using releaseDate: 2022-05-24 00:00:00 which we dont use time part just releaseDate: 2022-05-24 enough.
And also latestReleaseDate parts are invalid , you also need to fix them

usta
usta requested changes Dec 14, 2024
View reviewed changes
Copy link
Member

@usta usta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.12's date should be older than 2.3 series . Probably a typo exist

products/nginx-ingress-controller.md Outdated Show resolved Hide resolved
usta
usta requested changes Dec 16, 2024
View reviewed changes
products/nginx-ingress-controller.md Outdated Show resolved Hide resolved
products/nginx-ingress-controller.md Outdated Show resolved Hide resolved
products/nginx-ingress-controller.md Outdated Show resolved Hide resolved
products/nginx-ingress-controller.md Outdated Show resolved Hide resolved
products/nginx-ingress-controller.md Outdated Show resolved Hide resolved
products/nginx-ingress-controller.md Outdated Show resolved Hide resolved
products/nginx-ingress-controller.md Outdated Show resolved Hide resolved
products/nginx-ingress-controller.md Outdated Show resolved Hide resolved
products/nginx-ingress-controller.md Outdated Show resolved Hide resolved
products/nginx-ingress-controller.md Outdated Show resolved Hide resolved
@usta
Copy link
Member

usta commented Dec 16, 2024

@Jubblin if you wish i will make your mr/pr much simplier then you continue with missing dates ?

Jubblin and others added 2 commits December 16, 2024 10:38
@Jubblin
removed aliases as requested
70a0461
@usta
Use changelogTemplate , fix eols
becaafb 
Removed links
Used changelogTemplate
Fis eol dates
@usta
Copy link
Member

usta commented Dec 16, 2024

@Jubblin I have fixed your file a bit ( was not using changelogtemplate )

@usta
Copy link
Member

usta commented Dec 16, 2024

@captn3m0 looks ready for your review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usta usta usta approved these changes

@captn3m0 captn3m0 Awaiting requested review from captn3m0

Assignees
No one assigned
Labels
new-product This PR adds a new product to the website.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jubblin @usta @captn3m0 @chenrui333