Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new-product]: kyverno #5383

Merged
merged 4 commits into from
Jul 4, 2024
Merged

[new-product]: kyverno #5383

merged 4 commits into from
Jul 4, 2024

Conversation

Dentrax
Copy link
Contributor

@Dentrax Dentrax commented Jun 29, 2024

@Dentrax
add kyverno
4c96af1 
Signed-off-by: Dentrax <[email protected]>
@Dentrax
Copy link
Contributor Author

Dentrax commented Jul 1, 2024

Why this fails? 🤔 Any help would be appreciated.

captn3m0
captn3m0 reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions in comments. The description needs to be a bit more accessible.

I haven't checked the dates, but everything else should be good to merge soon. Thanks for your contribution 💯

products/kyverno.md Outdated Show resolved Hide resolved
products/kyverno.md Outdated Show resolved Hide resolved
products/kyverno.md Outdated Show resolved Hide resolved
products/kyverno.md Show resolved Hide resolved
products/kyverno.md Outdated Show resolved Hide resolved
products/kyverno.md Show resolved Hide resolved
products/kyverno.md Show resolved Hide resolved
products/kyverno.md Show resolved Hide resolved
products/kyverno.md Outdated Show resolved Hide resolved
products/kyverno.md Outdated Show resolved Hide resolved
@Dentrax
Copy link
Contributor Author

Dentrax commented Jul 2, 2024 •
edited
Loading

Thank you so much for your reviews and suggestions, @captn3m0! PTAL when possible. Rebased.

@captn3m0
Copy link
Member

captn3m0 commented Jul 2, 2024

Validation Error says:

Product Validator: Invalid releaseDate '2022-10-10' for kyverno.md#releases#1.8, expecting a value before eol (2022-02-01).

@Dentrax
update eol status
0fdc584 
Signed-off-by: Dentrax <[email protected]>
@Dentrax
Copy link
Contributor Author

Dentrax commented Jul 3, 2024

Thanks @captn3m0, should be good to go now.

captn3m0
captn3m0 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a slight change to use dates for EOL instead of false. LGTM once the build passes

@captn3m0 captn3m0 merged commit e241225 into endoflife-date:master Jul 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captn3m0 captn3m0 captn3m0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dentrax @captn3m0