Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework scanning formula #22

Open
wants to merge 1 commit into
base: experimental
Choose a base branch
from

Conversation

UnorderedSigh
Copy link

Bugfix: This un-nerfs scanners so they work again. I expect this fixes #7640 and fixes #8272.

This is identical to my PR endless-sky#8288 to endless-sky master.

Fix Details

Changes the scan formula to un-nerf scanners by using a gaussian drop-off and an adjusted size dependence. This retains the "minigame" from #6193 of ten seconds and cargo/outfit size penalties. It also adds a minimum scan time of 2 seconds. Scanning a Bulk Freighter will take longer than scanning a Sparrow... but you will be able to scan it.

  1. Minimum scan time of 2 seconds. A Sparrow in Hai space won't be scanned in one frame.
  2. More reasonable size dependence: to scan a Bulk Freighter at the same speed as a Sparrow, you only need 6x as many scanners instead of 40x.
  3. At full range, scans have a speed of 60% of maximum. Beyond this, it drops off much faster. This means they are mostly effective within the normal range.
  4. Scans go out to about 2 x the reported scan range, at which point the scan speed is only 12%, but you still finish scanning in 10 seconds. This key change is what makes scanning missions doable. It is also critical due to a pair of AI bugs described below.
  5. The numbers are tuned for a Navy surveillance gunship to take about 3 seconds to scan a light to medium warship sized craft in practical conditions.

This is balanced to allow well-designed early-game ships to do illegal missions with proper tactics; while scanning missions don't require dozens of scanners (just 10 seconds of patience).

Testing Done

Used @Pointedstick's test save with a Splinter and various outfit scanner counts. Spent some time around navy ships to see if they can scan me, and if I could scan them. Everything seems to work about as well as it did before scanners were nerfed into oblivion. However, scan time of bigger ships is still decidedly longer than smaller ones, as intended.

Free Worlds Scanning Mission

@Pointedstick's test save from #7640 has a scanner-equipped Splinter at the "go scan that Cruiser" mission in the Free Worlds campaign. The mission is doable with one scanner, and easy with three.

Morgan.Atrasco.txt

Illegal Missions

Here's another one from @movingpictures: a Heavy Shuttle up to no good, flying through heavily patrolled space:

Lenny.Lightfingers

Here's four from me: Sparrow, Heavy Shuttle, Clipper, and Blackbird, outfitted for smuggling, all with illegal missions through well-patrolled space, and you don't have enough fuel to reach the destination.

Aimet Taepip~3029-04-20 Sparrow Test.txt
Aimet Taepip~3029-04-18 Heavy Shuttle Test.txt
Aimet Taepip~3029-04-18 Clipper Test.txt
Aimet Taepip~3029-04-18 Blackbird Test.txt

I'm able to do all the illegal missions, but I fail if I'm careless. You have to use the old tricks: run away from Navy ships and the Parrot, ramscoop in systems with red stars, refuel by boarding if possible, and never land until your destination. The ships are all quite fast, though the Blackbird relies on afterburners in an emergency.

Big Ship Illegal Mission and AI Bugs

Aimet Taepip~3029-04-19 Ranoerek Test.txt

It generally takes the full ten seconds to scan my Ranoerek.

@Zitchas
Copy link
Member

Zitchas commented Mar 31, 2024

Sorry for being MIA for so long and unresponsive. Given that endless-sky#8288 was merged upstream, what is the status of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crime pays because scanning sucks Scanners have been nerfed too much
2 participants