Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: This un-nerfs scanners so they work again. I expect this fixes #7640 and fixes #8272.
This is identical to my PR endless-sky#8288 to endless-sky master.
Fix Details
Changes the scan formula to un-nerf scanners by using a gaussian drop-off and an adjusted size dependence. This retains the "minigame" from #6193 of ten seconds and cargo/outfit size penalties. It also adds a minimum scan time of 2 seconds. Scanning a Bulk Freighter will take longer than scanning a Sparrow... but you will be able to scan it.
This is balanced to allow well-designed early-game ships to do illegal missions with proper tactics; while scanning missions don't require dozens of scanners (just 10 seconds of patience).
Testing Done
Used @Pointedstick's test save with a Splinter and various outfit scanner counts. Spent some time around navy ships to see if they can scan me, and if I could scan them. Everything seems to work about as well as it did before scanners were nerfed into oblivion. However, scan time of bigger ships is still decidedly longer than smaller ones, as intended.
Free Worlds Scanning Mission
@Pointedstick's test save from #7640 has a scanner-equipped Splinter at the "go scan that Cruiser" mission in the Free Worlds campaign. The mission is doable with one scanner, and easy with three.
Morgan.Atrasco.txt
Illegal Missions
Here's another one from @movingpictures: a Heavy Shuttle up to no good, flying through heavily patrolled space:
Lenny.Lightfingers
Here's four from me: Sparrow, Heavy Shuttle, Clipper, and Blackbird, outfitted for smuggling, all with illegal missions through well-patrolled space, and you don't have enough fuel to reach the destination.
Aimet Taepip~3029-04-20 Sparrow Test.txt
Aimet Taepip~3029-04-18 Heavy Shuttle Test.txt
Aimet Taepip~3029-04-18 Clipper Test.txt
Aimet Taepip~3029-04-18 Blackbird Test.txt
I'm able to do all the illegal missions, but I fail if I'm careless. You have to use the old tricks: run away from Navy ships and the Parrot, ramscoop in systems with red stars, refuel by boarding if possible, and never land until your destination. The ships are all quite fast, though the Blackbird relies on afterburners in an emergency.
Big Ship Illegal Mission and AI Bugs
Aimet Taepip~3029-04-19 Ranoerek Test.txt
It generally takes the full ten seconds to scan my Ranoerek.