Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove a few mypy excludes #1954

Merged
merged 3 commits into from
Apr 27, 2023
Merged

remove a few mypy excludes #1954

merged 3 commits into from
Apr 27, 2023

Conversation

graingert
Copy link
Member

I accidentally read the "If you are seeing this, feel free to create a PR to cover the below files." note and became obligated

Summary

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@graingert graingert requested a review from Kludex April 26, 2023 16:57
Kludex
Kludex approved these changes Apr 26, 2023
View reviewed changes
Copy link
Sponsor Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @graingert ! Glad to have you back! 😃

@graingert graingert merged commit 913afe1 into encode:master Apr 27, 2023
@graingert graingert deleted the fix-some-mypy-issues branch April 27, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graingert @Kludex