Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UUID path parameter conversion more flexible #2806

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

edthrn
Copy link

@edthrn edthrn commented Dec 16, 2024

Summary

Based on @adriangb suggestion made in this discussion thread, here is a more flexible conversion of UUID path parameters.

UUID representation may vary depending on the system from which it is generated. Some systems may return an hex representation with no hyphens, while some others use upper-case letters.

From Python perspective, they are all valid:
image

Not handling those cases may yield to hard-to-debug 404 errors.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.

Copy link
Member

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)

Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. 🙏

Just a minor nitpick, as I think our test suite focus a lot on readability.

tests/test_convertors.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants