tests: branches coverage in responses.py, staticfiles.py, templating.py, middleware/wsgi.py and endpoints.py
#2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting.py`, `middleware/wsgi.py` and `endpoints.py`
Kludex
reviewed
Dec 18, 2024
starlette/templating.py
Outdated
| @@ -43,7 +43,7 @@ def __init__( | |||
| async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None: | |||
| request = self.context.get("request", {}) | |||
| extensions = request.get("extensions", {}) | |||
| if "http.response.debug" in extensions: | |||
| if "http.response.debug" in extensions: # pragma: no branch | |||
There was a problem hiding this comment.
This can be tested without the TestClient.
We have some tests that don't use the TestClient.
There was a problem hiding this comment.
That's right, I didn't think about it.
Added a test to the case based on other similar tests
Kludex
reviewed
Dec 18, 2024
Kludex
reviewed
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to issue #2452.
responses.py- 117→124Test with
samesite = Noneadded.staticfiles.py- 207→212Test with
etagnot matching theheaders["if-none-match"].templating.py- 46→56It seems that
TestClientadds{'http.response.debug': {}}to the scope on every HTTP request (line 310), making the statement alwaysTrue.Added
pragma: no branchand needs confirmation.middleware/wsgi.py- 124→exitself.response_startedis initialized asFalseinWSGIResponderand is only used inWSGIMiddleware(line 79). Removing theifstatement does not affect the tests.Added
pragma: no branchand needs confirmation.endpoints.py- 77→72It seems there are only two possible options inside the
whileloop.Added
pragma: no branchand needs confirmation.Checklist