Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure RedisBackend Listener Restarts on Resubscription #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lexthink
Copy link

@lexthink lexthink commented May 9, 2024

This pull request addresses a specific issue in the RedisBackend class where if all subscribers to a channel were unsubscribed, the listener task would complete and not restart upon new subscriptions. This led to a scenario where messages could be missed if new subscriptions were added after all others were removed.

@alex-oleshkevich
Copy link
Member

alex-oleshkevich commented May 9, 2024

We have the same concern for postgres backend. I am not sure if we want to have automatic reconnects in the backend. This can cause another issues like extra configuration (how many retries allowed? What is the back off value? What to do if Redis is permanently down?).

So I think that the best approach will be just to ignore disconnects and exit the context manager or raise the exception. Developers then can decide the proper solution for their needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants