Design tokens for Tooltip component #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the Emulsify logo src
🔵 Western University of Pennsylvania Blue
Design tokens for Banner component
Design tokens for Header component
Design tokens for Footer component
✅ Deploy Preview for emulsify-ui-kit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
callinmullaney
changed the base branch from
main
to
convert-components-to-sdc
callinmullaney
added
👉 Needs Work
callinmullaney
requested changes
Sep 10, 2024
There was a problem hiding this comment.
@mariannuar Can you take another look at this PR? I changed the parent branch to our convert-components-to-sdc release branch and there appears to be a lot of unintended changes. Likely due to this PR being originally branched from main. I THINK there should only be changes to src/components/tokens/_tokens.scss and the various src/tokens/*.json files so you may need to re-do this a bit 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Design tokens for the new Tooltip component
How to review this pull request