Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design tokens for the Announcement component #139

Merged
merged 10 commits into from
Aug 12, 2024
Merged

Design tokens for the Announcement component #139

merged 10 commits into from
Aug 12, 2024

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Aug 9, 2024 •
edited
Loading

Summary

Design tokens for the new Announcement component

How to review this pull request

  • To review, confirm that Announcement component exists and it has design tokens in Emulsify UI Kit

@mariannuar mariannuar added the 🚧 Work in Progress The PR is a work in progress. label Aug 9, 2024
@mariannuar mariannuar self-assigned this Aug 9, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 9, 2024 •
edited
Loading

✅ Deploy Preview for emulsify-ui-kit ready!

Name Link
🔨 Latest commit d4464c4
🔍 Latest deploy log https://app.netlify.com/sites/emulsify-ui-kit/deploys/66ba48b8cd7a350008f1f292
😎 Deploy Preview https://deploy-preview-139--emulsify-ui-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mariannuar mariannuar marked this pull request as ready for review August 10, 2024 08:27
@mariannuar mariannuar added 👍 Ready for Review Work is ready for review. and removed 🚧 Work in Progress The PR is a work in progress. labels Aug 10, 2024
@amazingrando amazingrando changed the title Announcement component Design tokens for the Announcement component Aug 12, 2024
amazingrando
amazingrando requested changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@amazingrando amazingrando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one request for a change.

src/tokens/transformed.tokens.json Outdated Show resolved Hide resolved
@mariannuar
Copy link
Collaborator Author

mariannuar commented Aug 12, 2024 •
edited
Loading

@amazingrando Updated. Thanks!

amazingrando
amazingrando requested changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@amazingrando amazingrando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar I found another change. Sorry!

src/components/tokens/_tokens.scss Outdated Show resolved Hide resolved
@mariannuar
Copy link
Collaborator Author

@amazingrando Now I think this is finally fixed! 😅 Thank you!

amazingrando
amazingrando approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@amazingrando amazingrando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mariannuar mariannuar merged commit 33bb1eb into main Aug 12, 2024
4 checks passed
@mariannuar mariannuar deleted the announcement-alert branch August 12, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amazingrando amazingrando amazingrando approved these changes

Assignees

@mariannuar mariannuar

Labels
👍 Ready for Review Work is ready for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariannuar @amazingrando