Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMULSIF-240: Convert Menus to support sdc #137

Merged
merged 4 commits into from
Aug 16, 2024
Merged

EMULSIF-240: Convert Menus to support sdc #137

merged 4 commits into from
Aug 16, 2024

Conversation

mariannuar
Copy link
Collaborator

Summary

This PR updates the yml file and stories.js file of each Menu component to meet the schema the Single Directory Component uses it

How to review this pull request

@mariannuar mariannuar added the 👍 Ready for Review Work is ready for review. label Aug 6, 2024
@mariannuar mariannuar self-assigned this Aug 6, 2024
cienvaras
cienvaras approved these changes Aug 14, 2024
View reviewed changes
Copy link

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, works as expected! 🚀

@cienvaras cienvaras added 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Passes Code Review Code is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. and removed 👍 Ready for Review Work is ready for review. labels Aug 15, 2024
Mari Nez and others added 2 commits August 15, 2024 18:38
@mariannuar mariannuar merged commit d4b545e into convert-components-to-sdc Aug 16, 2024
@mariannuar mariannuar deleted the emulsif-240-convert-menus-to-support-sdc branch August 16, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cienvaras cienvaras cienvaras approved these changes

Assignees

@mariannuar mariannuar

Labels
🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer.
Projects
Emulsify Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariannuar @cienvaras