Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMULSIF-235: Convert forms to support SDC #134

Merged

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Jul 24, 2024

Summary

This PR updates the yml file and stories.js file of all the Forms components to meet the schema the Single Directory Component uses it

How to review this pull request

@mariannuar mariannuar added the 👍 Ready for Review Work is ready for review. label Jul 24, 2024
@mariannuar mariannuar self-assigned this Jul 24, 2024
@joetower joetower added 👁 Review in progress Under review. and removed 👍 Ready for Review Work is ready for review. labels Aug 2, 2024
@joetower joetower self-requested a review August 2, 2024 17:29
Copy link

@joetower joetower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar 👍 Look good

@joetower joetower added 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Passes Code Review Code is approved by the reviewer. and removed 👁 Review in progress Under review. labels Aug 2, 2024
@mariannuar mariannuar merged commit 6c821a2 into convert-components-to-sdc Aug 5, 2024
@mariannuar mariannuar deleted the emulsif-235-convert-forms-to-support-sdc branch August 5, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants