EMULSIF-234: Convert card to support sdc #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joetower
added
👁 Review in progress
joetower
approved these changes
Aug 2, 2024
joetower
added
🎉 Passes Functional Review
joetower
requested changes
Aug 2, 2024
There was a problem hiding this comment.
@mariannuar I approved this and then noticed a missing empty line in the yml file. With that added this should be good to merge
| type: string | ||
| title: Link's url | ||
| description: The link's url of the card. | ||
| data: '#' |
There was a problem hiding this comment.
@mariannuar Actually, can you please add an empty line space here?
joetower
added
👉 Needs Work
…ulsify-ui-kit into emulsif-234-convert-card-to-support-sdc
…emulsify-ds/emulsify-ui-kit into emulsif-234-convert-card-to-support-sdc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
ymlfile andstories.jsfile of theCardcomponent to meet the schema the Single Directory Component uses itHow to review this pull request
npm run storybook