-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMULSIF-231: Convert Audio player to support SDC #129
EMULSIF-231: Convert Audio player to support SDC #129
Conversation
✅ Deploy Preview for emulsify-ui-kit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariannuar This looks good, but should the audio file actually play?
The path appears to be correct (in the yml file), but the audio file doesn't play within Storybook.
@joetower Thanks for asking. Yes, that's an issue related to the way webpack loads it. It's been like that since I'm not sure. I took a look at what's in the main branch and it wasn't working. I created a ticket to fix this in another branch https://app.clickup.com/t/36718269/EMULSIF-252 so the fix can go to the main branch instead of the release branch for everything related to SDC. But if you think the fix should be included in this ticket, that's totally fine for me |
@mariannuar Oh I think that's totally fine to merge this ticket in, then. 👍 |
…ulsify-ui-kit into emulsif-231-convert-audio-player-to-support-sdc
Summary
This PR updates the
yml
file andstories.js
file of theAudio player
component to meet the schema the Single Directory Component uses itHow to review this pull request
npm run storybook