Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMULSIF-231: Convert Audio player to support SDC #129

Conversation

mariannuar
Copy link
Collaborator

Summary

This PR updates the yml file and stories.js file of the Audio player component to meet the schema the Single Directory Component uses it

How to review this pull request

@mariannuar mariannuar added the 👍 Ready for Review Work is ready for review. label Jul 17, 2024
@mariannuar mariannuar self-assigned this Jul 17, 2024
Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for emulsify-ui-kit ready!

Name Link
🔨 Latest commit 3c3b41e
🔍 Latest deploy log https://app.netlify.com/sites/emulsify-ui-kit/deploys/669848c31846f6000768f448
😎 Deploy Preview https://deploy-preview-129--emulsify-ui-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mariannuar mariannuar changed the base branch from main to convert-components-to-sdc July 17, 2024 22:42
@joetower joetower self-requested a review August 1, 2024 22:40
@joetower joetower added 👁 Review in progress Under review. and removed 👍 Ready for Review Work is ready for review. labels Aug 1, 2024
Copy link

@joetower joetower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar This looks good, but should the audio file actually play?

The path appears to be correct (in the yml file), but the audio file doesn't play within Storybook.

@joetower joetower added the ❔ Question Further information is requested. label Aug 2, 2024
@mariannuar
Copy link
Collaborator Author

@joetower Thanks for asking. Yes, that's an issue related to the way webpack loads it. It's been like that since I'm not sure. I took a look at what's in the main branch and it wasn't working. I created a ticket to fix this in another branch https://app.clickup.com/t/36718269/EMULSIF-252 so the fix can go to the main branch instead of the release branch for everything related to SDC. But if you think the fix should be included in this ticket, that's totally fine for me

@joetower
Copy link

@mariannuar Oh I think that's totally fine to merge this ticket in, then. 👍

@joetower joetower added 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Passes Code Review Code is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. and removed ❔ Question Further information is requested. 👁 Review in progress Under review. labels Aug 13, 2024
@joetower joetower self-requested a review August 13, 2024 17:52
Mari Nez and others added 2 commits August 15, 2024 18:34
…ulsify-ui-kit into emulsif-231-convert-audio-player-to-support-sdc
@mariannuar mariannuar merged commit f7efa0f into convert-components-to-sdc Aug 16, 2024
@mariannuar mariannuar deleted the emulsif-231-convert-audio-player-to-support-sdc branch August 16, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants