Emulsif-67: Color contrast now meets WCAG AA standards #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WCAG AA standards
✅ Deploy Preview for emulsify-ui-kit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ULSIF-82-checkboxes-radios-cards-and-links
|
@mariannuar There are two pages that have contrast errors—buttons and table typography. See attached screenshots.
|
…ULSIF-82-checkboxes-radios-cards-and-links
|
@amazingrando Thank you!!! They are fixed now, please let me know your thoughts about the use of colors. Thanks! |
mariannuar
added
👍 Ready for Review
amazingrando
added
🎉 Passes Functional Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes color contrast for some components to meet WCAG AA Standard
How to review this pull request
Visit the following components in Storybook and note the Accessibility tab.
https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-button--button
https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-cards--card-horizontal
https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-cards--card-vertical
https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-menus--breadcrumbs
https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-menus--inline
https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-menus--social
https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-typography--headings
https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-typography-links--links
https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-typography--tables
https://deploy-preview-126--emulsify-ui-kit.netlify.app/?path=/story/components-pager--basic
Confirm there aren't color contrast issues anymore and they look like the design on Figma... I had to do some changes there. However, I saved a backup just in case we don't want those colors used.
Closing issues
Closes #113