Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emulsify-74: Fieldset #122

Merged
merged 3 commits into from
May 10, 2024
Merged

Emulsify-74: Fieldset #122

merged 3 commits into from
May 10, 2024

Conversation

robherba
Copy link
Contributor

@robherba robherba commented Apr 14, 2024 •
edited by amazingrando
Loading

Summary

Implement the required style adjustments for the fieldset component.

Tickets

How to review this pull request

  • Navigate to the fieldset component page in Storybook. (?path=/story/components-forms--textfields-examples)
  • Verify that the component appears correctly according to the design specifications.

Figma design:

https://www.figma.com/file/TuQAuw81mBRsaepz2HP7BX/Emulsify-UI-Kit?type=design&node-id=23098-1027&mode=design&t=GRfnOlrnvcNmwWn1-0

Captura de pantalla 2024-04-14 a la(s) 8 04 38 a  m

@robherba robherba added the 👍 Ready for Review Work is ready for review. label Apr 14, 2024
@robherba robherba self-assigned this Apr 14, 2024
@amazingrando amazingrando added 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Passes Code Review Code is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. and removed 👍 Ready for Review Work is ready for review. labels Apr 18, 2024
amazingrando
amazingrando approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@amazingrando amazingrando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@netlify Netlify
Copy link

netlify bot commented May 10, 2024 •
edited
Loading

✅ Deploy Preview for emulsify-ui-kit ready!

Name Link
🔨 Latest commit 67d26d1
🔍 Latest deploy log https://app.netlify.com/sites/emulsify-ui-kit/deploys/663e88bb8358c700088f0c31
😎 Deploy Preview https://deploy-preview-122--emulsify-ui-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mariannuar mariannuar merged commit 16cef9a into main May 10, 2024
4 checks passed
@mariannuar mariannuar deleted the emulsify-74-fieldset branch May 10, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amazingrando amazingrando amazingrando approved these changes

Assignees

@robherba robherba

Labels
🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer.
Projects
Emulsify Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robherba @amazingrando @mariannuar